OneBusAway / onebusaway-ios

OneBusAway for iOS, written in Swift.
Other
81 stars 33 forks source link

Update Eureka to address App Store Connect "references non-public selectors" warning #611

Closed wkulesza closed 1 year ago

wkulesza commented 1 year ago

After successfully building (and testing in simulator) a white-label app, following this great guide https://github.com/OneBusAway/onebusaway-ios/blob/main/Tutorials/WhiteLabel.md - kudos @aaronbrethorst , tried to archive the app and push to testflight. After it passed tests and got uploaded, this screen showed up: obraz

It turned out afterwards, the app did appear in the testflight, so this error didn't block this, but it's good to log it.

ualch9 commented 1 year ago

Likely caused by https://github.com/xmartlabs/Eureka/issues/2230. We need to update Eureka to 5.4.0 to address this.

ualch9 commented 1 year ago

Just did an App Store Connect upload with this change, and this warning no longer appears.