Speculative fix for “DUPLICATE_ITEM_IDENTIFIERS” and “EQUAL_IDENTIFIERS_HAVE_DIFFERENT_HASH_VALUES” crasher

OneBusAway / onebusaway-ios

OneBusAway for iOS, written in Swift.

Other

81 stars 33 forks source link

Speculative fix for “DUPLICATE_ITEM_IDENTIFIERS” and “EQUAL_IDENTIFIERS_HAVE_DIFFERENT_HASH_VALUES” crasher #620

Closed ualch9 closed 1 year ago

ualch9 commented 1 year ago

View models now has a guaranteed unique identifier (by UUID during initialization). This is fine for now, since we are directly consuming API results, but at the cost of potentially causing the entire table view to update when one item changes.

Ultimately, OBAListView implementation is flawed and requires a bit of fixing, so this is a stop gap.

aaronbrethorst commented 1 year ago

looks like a good step forward. nice work 👍

ualch9 commented 1 year ago

ah-- unit tests succeeded, but CI failing on the "Update xcresult bundle" step. Looks like forks can't access CI results here, for security. I'll move work onto this repo instead, but we should find a way to mark that step as optional for other contributors.