search

OneBusAway / onebusaway-ios

OneBusAway for iOS, written in Swift.
Other
87 stars 33 forks source link

Support "Full Page" screenshots #625

Open ualch9 opened 1 year ago

ualch9 commented 1 year ago

https://developer.apple.com/documentation/uikit/uiscreenshotservice

ualch9 commented 1 year ago

This issue number was misquoted, it is not completed yet. https://github.com/OneBusAway/onebusaway-ios/issues/623

RV784 commented 8 months ago

Hi, I would love to work on this task to understand the codebase and eventually contribute to OneBusAway under GSOC.

I build the code and added this full page screenshot functionality. I'm attaching the screen recording for the same.

https://github.com/OneBusAway/onebusaway-ios/assets/58266095/ecac0a53-69ab-4bc1-a432-e87da3ca61a2

RV784 commented 8 months ago

Before making a PR, I would like a brief discussion about how I did it and what would be the best practice to implement it in our code. CC: @aaronbrethorst