OneBusAway / onebusaway-ios

OneBusAway for iOS, written in Swift.
Other
81 stars 33 forks source link

Region Picker concurrency overhaul #630

Closed ualch9 closed 1 year ago

ualch9 commented 1 year ago

OBAKit Changes

UI recordings

Map Filter Custom Region

A delete action appears when editing a region. The delete button is disabled if it is the currently selected region.

Screenshot 2023-01-27 at 9 40 43 PM

Automatically choose region makes the region selection and disables the Picker.

Screenshot 2023-01-27 at 10 40 40 PM

About LocalizedAlertError

Normally, a is not LocalizedAlert will have an error description of just This operation couldn't be completed. LocalizedAlertError will instead create an error description using the name of the specific Error class/struct/enum, this makes it easier for developers to pinpoint the error location.

Screenshot demostrating LocalizedAlertError creating an error description using the Error's type name

OBAKitCore changes

OBAKitTests changes

Old recording

https://user-images.githubusercontent.com/22162410/212872734-5c3fcfbd-ac81-4da4-98eb-e4e78670d1bf.mov

ualch9 commented 1 year ago

Hm, want to try one more thing with one-time location authorization...

ualch9 commented 1 year ago

Hm, want to try one more thing with one-time location authorization...

Never mind, ready for review.

aaronbrethorst commented 1 year ago

@ualch9 can you take a quick pass through the commits here and squash where appropriate?

ualch9 commented 1 year ago

Rebased, added some comments, and fixed some localization. I hope this helps with your review.

aaronbrethorst commented 1 year ago

@ualch9 awesome, I'll review today.

aaronbrethorst commented 1 year ago

Awesome thanks @ualch9!