Closed ualch9 closed 1 year ago
Hm, want to try one more thing with one-time location authorization...
Hm, want to try one more thing with one-time location authorization...
Never mind, ready for review.
@ualch9 can you take a quick pass through the commits here and squash where appropriate?
Rebased, added some comments, and fixed some localization. I hope this helps with your review.
@ualch9 awesome, I'll review today.
Awesome thanks @ualch9!
OBAKit Changes
RenamableNavigationTitle
, a polyfill for iOS 16'snavigationTitle
editing.View.errorAlert
for displaying an error alert, regardless of whether the error is localized or not.LocalizedAlertError
, for creating a LocalizedAlert foris LocalizedAlert
oris not LocalizedAlert
.UI recordings
A delete action appears when editing a region. The delete button is disabled if it is the currently selected region.
Automatically choose region
makes the region selection and disables the Picker.About
LocalizedAlertError
Normally, a
is not LocalizedAlert
will have an error description of justThis operation couldn't be completed
.LocalizedAlertError
will instead create an error description using the name of the specific Error class/struct/enum, this makes it easier for developers to pinpoint the error location.OBAKitCore changes
RegionAPIService
to Concurrencyclass RESTAPIService
toany [protocol] APIService
.APIService.getData(for:)
APIService.getData(for:decodeAs:using:)
OBAKitTests changes
waitUntil
).DelegateTestingHelper.DidCallDelegateMethod
toOBAKitTests
.Old recording
https://user-images.githubusercontent.com/22162410/212872734-5c3fcfbd-ac81-4da4-98eb-e4e78670d1bf.mov