Fix: issue 625 - Githubissues

OneBusAway / onebusaway-ios

OneBusAway for iOS, written in Swift.

Other

74 stars 31 forks source link

Fix: issue 625 #716

Open RV784 opened 4 months ago

RV784 commented 4 months ago

Issue Link -> https://github.com/OneBusAway/onebusaway-ios/issues/625

Code Changes

Added UIScreenshotService delegate to AppDelegate
Adding OBAListView instance from loadView() instead of adding it as a subview in viewDidLoad()

CLAassistant commented 4 months ago

All committers have signed the CLA.

RV784 commented 4 months ago

@aaronbrethorst Did you get the chance to review this PR?

RV784 commented 4 months ago

Hey @aaronbrethorst thanks for the feedbacks

For point 1 and 3 I'm working on this. For second point can you please elaborate on the issue you are facing? Is it with screenshot functionality or the text is not clearly visible?

aaronbrethorst commented 4 months ago

@RV784 the rounded cells have black backgrounds, rendering the text illegible. Compare to the product UI where the text on this screen is clearly visible.