search

OneBusAway / onebusaway-iphone

OBA development has moved!
https://github.com/OneBusAway/OBAKit
Apache License 2.0
219 stars 117 forks source link

Trip Status Modifier #1475

Closed ualch9 closed 4 years ago

ualch9 commented 4 years ago

Fixes #1474 Closes #1476

ualch9 commented 4 years ago

Simulator Screen Shot - iPhone 8 - 2020-04-14 at 21 13 08

barbeau commented 4 years ago

@ualch9 I like the strike-through text in the arrivals list!

@ualch9 @aaronbrethorst One UI decision I need to make on Android, and I believe you do here on iOS as well - do we show vehicle markers on the map for canceled trips?

On Android, we show all vehicle markers for a given route on the map at the same time.

image

Scheduled vehicles without real-time info show up as gray markers with "SCHEDULED" in place of the delay value.

In this context, I'm leaning towards not showing the vehicle marker at all on the map if the trip is canceled. I believe this will be easier to understand to users than showing a vehicle marker with some kind of CANCELED annotation.

Any thoughts on iOS?

ualch9 commented 4 years ago

@barbeau I was planning:

1) Don’t let the user tap on a canceled trip in the arrivaldeparture tableview, display an alert instead informing the user that the trip is canceled. 2) If the user uses a deep-link, kick the user out of the vehicle marker map view and show a ‘trip canceled’ alert.

Also, are there any oba deployments that have implemented the CANCELED trip status modifier?

ualch9 commented 4 years ago

Screen Shot 2020-04-15 at 10 39 07 PM

ualch9 commented 4 years ago

@aaronbrethorst please review

barbeau commented 4 years ago

Also, are there any oba deployments that have implemented the CANCELED trip status modifier?

Not to my knowledge at this point. It sounds like MTA NYC may have this in production for their BusTime, but they aren't a production region for the native OBA apps, and mileage-may-vary when trying the native OBA apps with them (see http://regions.onebusaway.org/regions-v3.json for URL).

barbeau commented 4 years ago

So I may be wrong on the above - Puget Sound may have trips with CANCELED status live now. Please post the URL and responses if you find any!

barbeau commented 4 years ago

FYI, something else to consider - there are apparently SKIPPED stops that are supported within the OBA server now too. This effectively cancels one or more stops within a trip, but the remainder of the trip continues to run. I'm not sure what this looks like in the data yet.

aaronbrethorst commented 4 years ago

And also, regarding point 2 in the review above, please err on the side of using too many commits.