OneBusAway / onebusaway-webapp

Modern web app frontend for OneBusAway built in JavaScript with SvelteKit
GNU Affero General Public License v3.0
3 stars 1 forks source link

Added Dark Mode support to web app #9

Closed tarunsinghofficial closed 1 day ago

tarunsinghofficial commented 3 days ago

Fixes #5

Tasks done:

Screenshot:

bandicam2024-07-0120-08-45-733-ezgif com-crop

tarunsinghofficial commented 3 days ago

Works great! However, can you undo the indentation changes? it makes it hard to figure out what has and hasn't changed in files like GoogleMap.svelte. Also, did you run a formatter over these files or something? I'd love to make sure that we're using consistent formatting across the project.

I think my prettier vs code extension formatted these files and it gets auto saved. I'll try reformatting it back to previous version.

aaronbrethorst commented 3 days ago

Ahh, I see. Thank you! I’ll spend some time getting linting and formatting set up as a precondition for merging so that we can better guarantee that our formatting choices align :)

tarunsinghofficial commented 2 days ago

Ahh, I see. Thank you! I’ll spend some time getting linting and formatting set up as a precondition for merging so that we can better guarantee that our formatting choices align :)

Oh great! Thanks for it.

tarunsinghofficial commented 1 day ago

Ahh, I see. Thank you! I’ll spend some time getting linting and formatting set up as a precondition for merging so that we can better guarantee that our formatting choices align :)

For now, I have manually pushed the changes after undoing all the indentation changes. Let me know if it's correct! Thanks.