OneBusAway / onebusaway-windows-phone

Source code for the OneBusAway mobile app on Windows Phone
10 stars 14 forks source link

Change the RouteDetails.RefreshArrivalsForStops to use Safe Location #9

Open mvarley opened 9 years ago

mvarley commented 9 years ago

This change avoids an annoying error in which the user would get the error message "The location is currently unavailable: Initializing" when trying to view current arrival times for a stop and the location has not loaded yet. This scenario is very common when the default pane is set to "Favorites" and the user wants to see the real-time arrival state of buses at their favorite stops.

As a side effect of this, when viewing a stop and the location has not yet loaded, the map will not zoom into the user's location until location is loaded, but real-time arrival information will load without needing the current location. This is contrasted with an error message that kicks the user back to the home screen.

Sinorm commented 9 years ago

Thanks for submitting this patch, it looks good at a glance. I'm travelling right now, but I'll give it a look when I'm back and try to get an update out for the app with a few other fixes soon.

sdwilsh commented 7 years ago

@Sinorm - any chance you could get this merged? I get this message all the time :/

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.