OneBusAway / wayfinder

Modern web app frontend for OneBusAway built in JavaScript with SvelteKit

GNU Affero General Public License v3.0

4 stars 1 forks source link

New Search UI #55

Closed aaronbrethorst closed 1 week ago

aaronbrethorst commented 1 week ago

Remaining Tasks

[x] Build out SearchPane.svelte handleLocationClick()
[x] Build out SearchPane.svelte handleStopClick()
[x] Build out SearchPane.svelte handleRouteClick()
[x] Make sure that the search results pane never grows larger than the bottom edge of the screen, and is scrollable (similar to the StopPane or ModalPane, but in the opposite direction). For an example of this, search for "Seattle"

Ahmedhossamdev commented 1 week ago

@aaronbrethorst

Done

Ahmedhossamdev commented 1 week ago

@Ahmedhossamdev I think this is looking great! The one big change I'd like to see here is for you to move the switch driven logic for determining behavior depending on Google Maps or OSM into the map provider files GoogleMapProvider.js and OpenStreetMapProvider.js using a common 'interface'.

Nice idea; I will refactor it

Ahmedhossamdev commented 1 week ago

Hello @aaronbrethorst,

I’ve encapsulated everything in the code now. The stop markers and info windows are properly managed within the GoogleMapProvider and OpenStreetProvider classes. Both adding and removing stop markers, as well as handling the info windows, are now fully self-contained.

Please feel free to review and let me know if there’s anything else you’d like to adjust.

aaronbrethorst commented 1 week ago

@Ahmedhossamdev I see a couple merge conflicts on this PR. Can you resolve them? Let me know if I can help you with that.

Ahmedhossamdev commented 1 week ago

Done

@aaronbrethorst