search

OneCricketeer / apache-kafka-connect-docker

[KAFKA-9774] Un-official Docker Image for Apache Kafka Connect
https://issues.apache.org/jira/browse/KAFKA-9774
Apache License 2.0
36 stars 16 forks source link

Making it so that forks of the project don't attempt to build and deploy from a github action when there is a push to master. #10

Closed Sounie closed 2 years ago

Sounie commented 2 years ago

This is based on what I've seen at: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-only-run-job-for-specific-repository

Disclaimer: I haven't tried this on my master branch, but will pull it down and verify it if you merge it in.

OneCricketeer commented 2 years ago

It should fail for any other fork because you wouldn't have my dockerhub password

Sounie commented 2 years ago

Yeah, I can confirm that the existing setup currently fails.

It looks a bit ugly and wastes processing resources though, so it would be nice if something like this could stop the action earlier.

OneCricketeer commented 2 years ago

Ideally, only tagged commits get built, but I'm satisfied with requiring PRs to merge to master

Sounie commented 2 years ago

Confirming this behaves as expected. 👍