OneDeadKey / kalamine

Keyboard Layout Maker
MIT License
105 stars 29 forks source link

Dead keys in the `1dk` layer ? #55

Open fabi1cazenave opened 8 months ago

fabi1cazenave commented 8 months ago

It’s now a bit unclear whether dead keys are accepted in the 1dk layer or not.

As a matter of fact, I’ve never put much effort in maintaining this feature because I believe Compose makes much more sense than any double dead key. But I’ve revised my opinion, mostly because of @Ced-C ’s idea of having a dead key in 1dk 1dk instead of Shift+1dk for Bépolar.

Right now it seems to me that :

We should either make sure this feature works everywhere or ban it explicitly.

robinmoussu commented 8 months ago

On mac, it’s as simple as adding <when state="1dk" next="diaeresis" />

ergol.keylayout.txt

diff --git a/0_99_2/ergol.keylayout b/0_99_2/ergol.keylayout
index bbc2aff..3425634 100644
--- a/0_99_2/ergol.keylayout
+++ b/0_99_2/ergol.keylayout
@@ -707,6 +707,7 @@
   <actions>
     <action id="dead_1dk">
       <when state="none" next="1dk" />
+      <when state="1dk" next="diaeresis" />
     </action>
     <action id="dead_diaeresis">
       <when state="none" next="diaeresis" />
fabi1cazenave commented 8 months ago

[EDIT] adding this snippet that you put in another issue (#56)

diff --git a/0_99_2/ergol.keylayout b/0_99_2/ergol.keylayout
index 3425634..fc4c137 100644
--- a/0_99_2/ergol.keylayout
+++ b/0_99_2/ergol.keylayout
@@ -1356,7 +1356,7 @@
   </actions>

   <terminators>
-    <when state="1dk"        output="*¨" />
+    <when state="1dk"        output="*" />
     <when state="grave"      output="`" />
     <when state="acute"      output="´" />
     <when state="circumflex" output="^" />

ergol.keylayout.txt

fabi1cazenave commented 8 months ago

Looks like double dead keys are difficult to support on Windows :

https://bepo.fr/wiki/Windows#Probl%C3%A8mes_avec_certains_logiciels

robinmoussu commented 7 months ago

Isn’t this issue fixed and could be closed ?

fabi1cazenave commented 7 months ago

I wish… but there are still a lot of corner cases related to this.

fabi1cazenave commented 7 months ago

Reopening. Still a couple corner cases to fix.

Geobert commented 6 months ago

With https://github.com/OneDeadKey/kalamine/pull/114 landed, is this one solved?