We should use a single character to display 1dk

[robinmoussu]

Would it be possible to modify the terminator of 1dk to be a single character?

diff --git a/0_99_2/ergol.keylayout b/0_99_2/ergol.keylayout
index 3425634..fc4c137 100644
--- a/0_99_2/ergol.keylayout
+++ b/0_99_2/ergol.keylayout
@@ -1356,7 +1356,7 @@
   </actions>

   <terminators>
-    <when state="1dk"        output="*¨" />
+    <when state="1dk"        output="*" />
     <when state="grave"      output="`" />
     <when state="acute"      output="´" />
     <when state="circumflex" output="^" />

ergol.keylayout.txt

[robinmoussu]

We could also use a nice unicode character instead of *

[robinmoussu]

Or even make it empty, so that website like http://dactylotest.free.fr/dactylotest/ do not complain about a weird dead key that look like a mistake. (I just tested that it works)

[fabi1cazenave]

Closing as a duplicate of #55.

[robinmoussu]

Technically that’s not a duplicate. I wasn’t clear, but on mac-os when you press a dead key, a hint may be displayed, and the terminator is used for the hint. Currently *¨ is used as a hint. I think that we should either use * or even an empty hint (the later is probably best). I let-you re-open this issue unless you want to handle everything in #55.

[fabi1cazenave]

This is expected as for all other dead keys on macOS (and all non-1dk dead keys on modern Linux).

This terminator is currently *¨, which is the way Kalamine YAML/TOML files describe a dead diaeresis. And it gets into the .keylayout output because Kalamine has not tried to parse dead keys in the 1dk layer, precisely.

So yes, it is a duplicate : this one-liner is another part of the solution for the same bug (i.e. what a proper implementation of dead keys in the 1dk layer should produce), and it would be much easier to track the discussion in that ticket.

[fabi1cazenave]

If you think that * is not a good hint for macOS (and I agree I’d like to see a smaller symbol), feel free to open another issue but please, with a screenshot or a patch proposal that is NOT related to the lack of dead key support in the 1dk layer.