search

OneDrive / onedrive-sdk-dotnet-msa-auth-adapter

Other
26 stars 22 forks source link

Desktop CredentialVault does not seem to work #30

Open paya-cz opened 7 years ago

paya-cz commented 7 years ago

The implementation for CredentialVault for desktop creates the vault file in the same directory as my .exe:

https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/blob/master/src/OneDrive.Sdk.Authentication.Desktop/CredentialVault.cs#L42

But it tries to load it from AppData directory:

https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/blob/master/src/OneDrive.Sdk.Authentication.Desktop/CredentialVault.cs#L50

Which of course always fails. I assume the AddCredentialCacheToVault wanted to do something like this?

using (var outStream = File.OpenWrite(this.GetVaultFilePath()))
adamsipos commented 7 years ago

Having the same problem, agree with your assessment.

23W commented 7 years ago

@adamsipos, Do you know when new version with this fix will be released?

adamsipos commented 7 years ago

@23W If you're referring to my fix, that won't be merged. When I sent the pull request I was surprised to find that I'd have to sign an agreement with Microsoft about my contribution that I do not wish to do, so I simply closed my PR. I don't know when the MS team will fix it.

23W commented 7 years ago

@adamsipos Thank you. I'm disappointed that MS doesn't fix this issue yet.

escape-llc commented 6 years ago

This appears to be fixed in commit https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/commit/b3c0bde3c47366591bbfaef69d9cdc2afde567af can someone verify and close this item?