OneDrive / onedrive-sdk-dotnet-msa-auth-adapter

Other
26 stars 22 forks source link

update uwp reference #48

Closed daboxu closed 7 years ago

daboxu commented 7 years ago

hi @pingzing , could you please have a look at it? I updated several dependencies and tests.

pingzing commented 7 years ago

Looks good to me. Compiles and runs fine on my Raspberry Pi 3.

I've made a few changes to my fork since the PR got merged. They're fairly minor, so it might be just easier to list them here, rather than go through the whole fork-and-PR song and dance.

IotFriendlyWebDialog.xaml, starting at Line 228:

From this:

 <Grid x:Name="WebViewContainer">
        <WebView x:Name="DialogWebView"
                 Height="{StaticResource ContentDialogMaxHeight}"         
                 Width="{StaticResource ContentDialogMaxWidth}"
                 NavigationStarting="DialogWebView_NavigationStarting"
                 NavigationCompleted="DialogWebView_NavigationCompleted"                 
                 Source="{x:Bind WebViewSource, Mode=TwoWay}"
                 />
    </Grid>

To this:

<WebView x:Name="DialogWebView"
             Height="400"
             Width="400"
             NavigationStarting="DialogWebView_NavigationStarting"
             NavigationCompleted="DialogWebView_NavigationCompleted"/>

IotFriendlyWebDialog.xaml.cs, line 46:

From this:

WebViewSource = requestUri;

to this:

this.DialogWebView.Navigate(requestUri);

(this also allows us to remove the INotifyPropertyChanged implementation, and the WebViewSource property).

The changes to the XAML are to help with some issues with the WebView and scrolling.

The changes to the C# code are to fix a potential soft-lock if the user logged out and back in multiple times.

daboxu commented 7 years ago

@pingzing thanks for the feeback, pushed a commit for the change.