search

OneDrive / onedrive-sdk-ios

OneDrive SDK for iOS
https://dev.onedrive.com
Other
101 stars 88 forks source link

Deprecated API Usage (UIWebView) #213

Closed wang1925 closed 4 years ago

wang1925 commented 4 years ago

Hi,

I've just tried to upload the new version of the app to App Store, but unfortunately I get a message from the Apple itself:

"Dear Developer,

We identified one or more issues with a recent delivery for your app. Your delivery was successful, but you may wish to correct the following issues in your next delivery:

ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs starting from April 2020 . See https://developer.apple.com/documentation/uikit/uiwebview for more information.

After you’ve corrected the issues, you can upload a new binary to App Store Connect.

Best regards,

The App Store Team"

This problem will affect submission of the app. Can you fix it？Looking forward to your reply.

All best!

luisangelsm commented 4 years ago

It looks to me that this sdk is deprecated, read this: https://github.com/OneDrive/onedrive-sdk-ios/issues/209

This issue is a blocker for whoever is using the sdk, I wonder if there is a migration guide to move from the onedrive sdk to Microsoft Graph SDK.

OneSecure commented 4 years ago

Since nobody want to do migrating, I do. My work looks fine. Maybe can help others. Look https://github.com/OneSecure/onedrive-sdk-ios/commit/7a390f964ac1c893fb2ab4b80d05e3ed4388392c

I don't understand why Microsoft abandoned this SDK.

wang1925 commented 4 years ago

Since nobody want to do migrating, I do. My work looks fine. Maybe can help others. Look OneSecure@7a390f9

I don't understand why Microsoft abandoned this SDK.

Thans for your work，Great job

kungfuslippers commented 4 years ago

Hi OneSecure@7a390f9

I tried to get your UIWebView -> WKWebView changes by updating the reference to OneDriveSDK in my Podfile from :

pod 'OneDriveSDK', '1.3.0' to: pod 'OneDriveSDK', :git => 'https://github.com/OneSecure/onedrive-sdk-ios.git'

and all builds ok but I still get references to UIWebView in

ADAuthenticationContext.h ADAuthenticationViewController.h ADAuthenticationViewController.m ADAuthenticationWebViewController.h ADAuthenticationWebViewController.m

I checked your commits and it seems as though you updated the files so unsure where the issue for me might be - any ideas?

OneSecure commented 4 years ago

I think you can NOT use pod command. You must use git clone instead.

dlpigpen commented 4 years ago

@kungfuslippers I got this error [!] Unable to find a specification for ADAL (~> 1.2) depended upon by OneDriveSDK/Auth.

Could you please give a hint?