OneDrive / onedrive-sdk-python

OneDrive SDK for Python! https://dev.onedrive.com
MIT License
1.08k stars 189 forks source link

Error handling on reply address configuration error #110

Closed dtheodor closed 3 weeks ago

dtheodor commented 7 years ago

The code in http_response.py is not correctly handling this error data I receive from Microsoft

if "error" in message:
  if type(message["error"]) == dict:
    raise OneDriveError(message["error"], self.status)
  else:
    raise Exception(str(message["error"]))
{
    "error": "invalid_client",
    "error_description": "AADSTS50011: The reply address 'https://<...?' does not match the reply addresses configured for the application: \'b675667c-2e92-4df6-a6f3-f49db54b2955\'. More details: not specified\\r\\nTrace ID: d98448a4-5338-4457-b3d0-6a99e57c0500\\r\\nCorrelation ID: 3cbb8729-e920-4612-ad4a-4a52e24233af\\r\\nTimestamp: 2017-06-14 10:40:57Z",
    "error_codes": [50011],
    "timestamp": "2017-06-14 10:40:57Z",
    "trace_id": "d98448a4-5338-4457-b3d0-6a99e57c0500",
    "correlation_id": "3cbb8729-e920-4612-ad4a-4a52e24233af"
}

So I'm getting an unhelpful general Exception that has hidden away any useful information on the error. Is this intended behavior?

baywet commented 3 weeks ago

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #209 for more information