OneDrive / samples

Contains samples, scenarios, and guidance for integrating with OneDrive and SharePoint drives, drive items, and files.
MIT License
58 stars 59 forks source link

OneDrive File Picker v8 - Missing code example and documentation for handling shared libraries #37

Open LukaszGawlikBridge opened 1 year ago

LukaszGawlikBridge commented 1 year ago

Describe the bug There is missing code example and documentation for handling shared libraries. It is complex to make it work. Making javascript-basic example to work with shared libraries requires not obvious adjustments:

  1. Configuration, set sharedLibraries: true (it is obvious, it's described in documentation, it's OK)
  2. Adjusting code for getting token (auth.js->getToken) - it's not covered by documentation or any example (there is some handling in csharp-basic but at the same time pivots->sharedLibraries is not set to true). image

Expected behavior There should be code example for sharedLibraries:true (the best would be some basic javascript code). It should be also covered clearly by documentation how to make shared libraries to work.

patrick-rodgers commented 1 year ago

Can you share a bit more on where you are/got stuck or what information is missing from the docs? We can't have individual samples that cover every possible scenario but do want to ensure there is enough information folks can figure out how to load the control.

LukaszGawlikBridge commented 1 year ago

I was facing following problem when trying to make javascript-basic to work with shared libraries (configuration typesAndSources->sharedLibraries: true), when clicking on shared team there was an exception, because handling authentication for command.type = "ms-graph" was missing.

image

image

JCrew0 commented 10 months ago

Hey @LukaszGawlikBridge, I'm going through and looking at some of the older issues. Did anyone ever address this? If not, I can triage for someone to update the docs accordingly. Thanks!

LukaszGawlikBridge commented 10 months ago

Hello @JCrew0 , as far as I know it has not been addressed yet (I have not been informed about any changes in documentation regarding this topic).

Regards Lukasz

JCrew0 commented 8 months ago

@LukaszGawlikBridge, just an update: this is still in my backlog. Will hopefully get to it soon