search

OneGet / MicrosoftDockerProvider

Provider to search, save and install Docker
Other
135 stars 56 forks source link

Update docker engine version (actual version is 19.03.11) #72

Closed bbqrob closed 3 years ago

bbqrob commented 4 years ago

Is it possible to use the latest docker engine using this provider? Latest version is v19.03.11 according to this.

andyfisher100 commented 4 years ago

Who are the project owners for this? It's getting massively out of date. 19.03.5 was released back in November 2019 and there are loads of bug fixes for windows containers since

@cwilhit @jayshah-msft Can you guys help?

james-nesbitt commented 4 years ago

I am starting to look at this now. I am just trying to discover what needs to change.

FYI: I am on the Mirantis side, working on Docker-EE

james-nesbitt commented 4 years ago

Quick update:

  1. I've isolated the docker/mirantis CI processes which are needed for this. They are usable to process and update, but we will likely need to change out some signing key/certs (current docker cert expires 2021, so we may use it as it atm)
  2. I have had little success fining the correct MS partner rep for changes to be made on the MS side, however I still have some leads that I am following up with. If anybody on the MS side reads this that can help, please contact me.
jsturtevant commented 4 years ago

@cwilhit are you able to help here?

cwilhit commented 4 years ago

James and I are chatting offline and investigating.

gerritsen commented 4 years ago

@james-nesbitt and @cwilhit Hope you can fix this soon. It would be nice to have the latest docker version to check if the stability has improved. Thanx for your work! Do you know of an alternative way to get and install the latest docker release for windows server 2019?

james-nesbitt commented 4 years ago

@gerritsen you might try the incoming install replacements: https://docs.mirantis.com/docker-enterprise/v3.1/dockeree-products/docker-engine-enterprise/dee-windows.html

My understanding is that OneGet is not the long term support path for containers on windows (I am not an authority on the topic, just a guy with a wrench)

gerritsen commented 4 years ago

@gerritsen you might try the incoming install replacements: https://docs.mirantis.com/docker-enterprise/v3.1/dockeree-products/docker-engine-enterprise/dee-windows.html

My understanding is that OneGet is not the long term support path for containers on windows (I am not an authority on the topic, just a guy with a wrench)

Thank you for this info. It will help us greatly!

thecloudtaylor commented 4 years ago

We are intending to continue using OneGet for the Docker Engine installation as the pattern has been established and customers, automation and process already use it. For new software other approaches will likely be used.

james-nesbitt commented 4 years ago

In discussion with Microsoft, it is my intention to get proper refactoring of the implementation - new signing certs and corrected infra ownership of storage, so that OneGet can be supported in the long run.

In discussion we are targeting correct delivery of the next patch release (1st week of August.) This should allow earlier missed release to also be installed.

hoerup commented 3 years ago

I'm not sure if this is the right place to post this, but i just updated to 19.03.11 viainstall-package docker -providername DockerMSFTProvider -Update - so far so good.

But the old version was reported as 

Server: Docker Engine - Enterprise
 Engine:
  Version:          19.03.5

but the new is 

Server: Docker Engine - Enterprise (Unlicensed - not for production workloads)
 Engine:
  Version:          19.03.11

If i downgrade to 19.03.8 - there's no note regarding unlicensed

Server: Docker Engine - Enterprise
 Engine:
  Version:          19.03.8
james-nesbitt commented 3 years ago

Interesting. I didn't expect that the fix was live yet. With regards to the unlicensed comment, that is in discussion right now and is to be addressed on the Mirantis/Docker side (but please note that I am not an authority on this topic)

On the Mirantis/Docker side we did get updates into the one-get manifest, which was passed to MSFT, but I didn't think it would be reflected in OneGet yet as the location of the manifest is different right now, and we are still negotiating updating the processes to reflect that.

Note that a new patch release is heading out the door soon, so I'll get that updated again (not automated yet until we get confirmation from MSFT that we are good)

james-nesbitt commented 3 years ago

A follow up on the Unlicensed label in the engine version - I have been told that this has already been addressed for versions 19.03.12/18.09.13 for Windows. When we get the oneget update for those versions, there will be no such declaration.

james-nesbitt commented 3 years ago

We have update the one-get manifest for docker to the 19.03.12/18.09.13 versions, so they may be available when the update is read by OneGet.

bbqrob commented 3 years ago

Great, works fine now.

tfenster commented 3 years ago

Does it? I just now updated and still see 

Server: Docker Engine - Enterprise (Unlicensed - not for production workloads)
 Engine:
  Version:          19.03.11
  API version:      1.40 (minimum version 1.24)
  Go version:       go1.13.11
  Git commit:       0da829ac52
  Built:            06/26/2020 17:19:32
  OS/Arch:          windows/amd64
  Experimental:     false
tfenster commented 3 years ago

Just to confirm, for whatever reason it took a couple of weeks for me, but now it also works:

Server: Docker Engine - Enterprise
 Engine:
  Version:          19.03.12
  API version:      1.40 (minimum version 1.24)
  Go version:       go1.13.13
  Git commit:       f295753ffd
  Built:            08/05/2020 19:26:41
  OS/Arch:          windows/amd64
  Experimental:     false
james-nesbitt commented 3 years ago

Old issue, but just for peace of mind - we update the manifest for docker 20.10.0 yesterday, so that should show up.