search

OneGet / MicrosoftDockerProvider

Provider to search, save and install Docker
Other
133 stars 55 forks source link

Make install output better #9

Closed friism closed 8 years ago

friism commented 8 years ago

Starting the docker service after the restart doesn't make sense - it'll start automatically.

cc @taylorb-microsoft

jayshah-msft commented 8 years ago

I have added the restart request conditional based on whether containers was installed or not. I need to merge it to the developer branch. Will do that. I did multiple tests and in some of my tests I saw that the service had not started after the reboot, hence I called it out.

Cheers, Jay!

friism commented 8 years ago

That'd be strange - it's a normal Windows Server, if that doesn't start, we have bigger problems.

@jayshah-msft if you're still seeing this, can you provide a repro of how the service doesn't start.

jayshah-msft commented 8 years ago

As I mentioned it wasn't a consistent repro. But I will run a few more tests and if this does repro, I will forward the steps to you.

Cheers, Jay!

friism commented 8 years ago

rebased

jayshah-msft commented 8 years ago

Took this, signed the files and updated the README.md

Cheers, Jay!