Improve File Upload Implementation

[href]

• We should support more file types (I see it's easy to do) - like zip, xls, doc.
• The files view would be better if we used a list instead of a grid.
• I think we should stop the user from uploading a file with the same name twice.
• It would be nice if the file type was displayed next to each file link (http://fortawesome.github.io/Font-Awesome/icons/#file-type) - This could be done by adding a two css classes to each file, like 'file-type file-type-pdf'.

[msom]

Other thoughts:

• Use altert boxes for consistency (together with a reload of the page?)
• Localize error messages

[href]

I think alert boxes could benefit from a js api. I would recommend writing a react based component akin to the confirmation dialog. Something like this would then trigger an alert right away:

show_alert("My alert");
show_message("My alert", 'alert');

It's a bit of a rewrite of the server-side alerts but it's shouldn't be too much code. I think that's preferable to a full page reload.

As for localizing, a locale.js is missing anyway and its addition would make sense. Have a look at how seantis.reservation does locale.js for an example:

https://github.com/seantis/seantis.reservation/blob/master/seantis/reservation/js/locale.js

[href]

Even more improvements:

• detect duplicate files (show the existing file to the user if he tries to upload en existing file)
• have the ability to replace an image with another one - the link must change with this for the cache to be refreshed, so we would have to update all existing links