Closed kasperisager closed 3 years ago
@kasperisager Thanks for the help with accessibility!
Could you check the styling in Safari? I'm seeing the checkbox fields getting cut off.
@dwwoelfel I'm looking into it 👍
Should be fixed now.
This would be really cool to merge in! Any ETA on moving it forward to improve access in the explorer?
This pull request focuses on improving the keyboard and screen reader operability of the data explorer by making the following changes and then a few more:
Each individual query is now implemented as a named region, making it easier to navigate between queries using a screen reader.
The field and variable tree is now implemented as a nested unordered list, communicating proper semantics to users of assistive technologies. The individual lists have also been assigned accessible names to make it easy to identity their purpose and association to their parent, such as "Fields for type" or "Variables for field". Do let me know if I got the terminology right 😄
All interactive components are now implemented as
<button>
elements, ensuring that they correctly communicate to users of assistive technology that they can be interacted with and that standard keyboard interaction works as expected.The state of fields and variables is now communicated to users of assistive technologies, such as if they're expanded (using
aria-expanded
) or selected (usingaria-selected
).