search

OneGraph / graphiql-explorer

Explorer plugin for GraphiQL
MIT License
904 stars 97 forks source link

[UI/UX] Change asterisk to exclamation mark #7

Closed FluorescentHallucinogen closed 5 years ago

FluorescentHallucinogen commented 5 years ago

Change asterisk to exclamation mark for non-nullable fields that is a common in the GraphQL world.

Before:

before

After:

after

FluorescentHallucinogen commented 5 years ago

@dwwoelfel @sgrove @rofrischmann Please review and merge this pull request.

robinweser commented 5 years ago

Hmm, while an exclamation mark is indeed the common symbol for non-nullable fields in GraphQL, I think the asterisk is way more common and widely used symbol for required fields and thus probably more user-friendly for users other than GraphQL devs.

langpavel commented 5 years ago

I like ! and more, what about bold?

sgrove commented 5 years ago

Keeping this as-is for now, will revisit at the next visual refresh