OneKeePass / mobile

A secure password manager for iOS and Android platforms
GNU General Public License v3.0
76 stars 5 forks source link

Proprietary components added #23

Open IzzySoft opened 2 weeks ago

IzzySoft commented 2 weeks ago

Today's updated added several proprietary components, essentially making the app no longer fully FOSS:

Hence I'll have now to either

The latter would be seen as a "red flag" for many folks looking for a good password manager – and in this case even violate inclusion criteria of the repo, as MLKit is also marked as Tracker – so I will for now take option 2, waiting for clarification. Options from your end would be:

Thanks in advance for consideration! I hope we can find a good solution here, so I can re-enable updates soon.

jeyasankar commented 2 weeks ago

Thanks @IzzySoft for detailed analyzes.

Indeed it seems these services were included by some react native third party package meant for QR code scanning. I will try to find alternative solutions to remove these dependencies. Till that time please use option 2 as you suggested. I will update you when I have a solution for the next version

IzzySoft commented 2 weeks ago

I'm no Android dev (and have no idea about RN development at all), so I cannot help with that much. Checking the definitions of my library scanner for a fitting match, I only found react-native-vision-camera explicitly naming RN and checked with their package.json, not seeing anything obviously suspicious. But looking into yours, that seems exactly what you are using, so I'm a bit confused. Obviously the "vision" part of its name points to the very same component of MLKit, though I don't see where the dependency is declared :shrug: But it clearly does depend on it:

import com.google.mlkit.vision.barcode.common.Barcode

Not sure what a good alternative would be. Fingers crossed you find one easily, which then is also easy to "swap in" :crossed_fingers: