OK-33920, OK-33943: Switch dApp connected account issues

originalix commented 1 week ago

Summary by CodeRabbit

新功能
- 增强了账户管理逻辑，特别是在多个连接账户和主账户对齐的场景下。
- 改进了交易处理和验证，提升了Vault类的功能。
- 简化了dApp账户与主账户的同步逻辑，减少了复杂性。
错误修复
- 增强了错误处理机制，确保交易广播时检查有效的RPC URL。
文档
- 更新了方法签名以反映新逻辑和参数变更。

codesandbox[bot] commented 1 week ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

本次变更涉及多个文件，主要集中在账户管理和交易处理的逻辑增强。ServiceDApp 类新增了 shouldAlignPrimaryAccount 方法，以优化主账户的对齐判断。Vault 类更新了交易构建和验证逻辑，提升了错误处理能力。useDappAccountSwitch 钩子添加了条件检查，以控制账户切换行为。SyncDappAccountToHomeProvider 文件简化了账户同步逻辑，移除了不必要的网络兼容性检查。

Changes

文件路径	变更摘要
packages/kit-bg/src/services/ServiceDApp.ts	新增方法 `shouldAlignPrimaryAccount`，更新 `getConnectedAccountsInfo` 和 `syncDappAccountIfPrimaryMode` 方法以增强账户管理逻辑。
packages/kit-bg/src/vaults/impls/ton/Vault.ts	更新 `buildEstimateFeeParams`、`buildEncodedTx` 和 `broadcastTransactionFromCustomRpc` 方法，增强交易处理和错误管理。
packages/kit/src/views/DAppConnection/hooks/useDappAccountSwitch.ts	在 `sync` 函数中添加条件检查，以控制账户同步行为。
packages/kit/src/views/Discovery/components/SyncDappAccountToHomeProvider.tsx	移除 `useActiveAccount` 钩子，简化账户同步逻辑，更新 `syncDappAccountToWallet` 函数签名。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DApp
    participant ServiceDApp
    participant Vault

    User->>DApp: 连接账户
    DApp->>ServiceDApp: 获取连接账户信息
    ServiceDApp->>ServiceDApp: 应用主账户对齐逻辑
    ServiceDApp-->>DApp: 返回账户信息
    DApp->>Vault: 构建交易
    Vault->>Vault: 处理交易参数
    Vault-->>DApp: 返回交易信息
    DApp-->>User: 显示交易信息

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` or `Summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

OneKeyHQ / app-monorepo