fix: duplicate local btc history OK-34010

weatherstar commented 6 days ago

Summary by CodeRabbit

新功能
- 引入了 isAccountCompatibleWithTx 函数，用于检查账户与交易的兼容性。
- 在 IOnChainHistoryTx 类型中新增了 key 属性，以提供唯一标识符。
改进
- 更新了 fetchAccountHistory 和 updateAccountLocalConfirmedTxs 方法的交易处理逻辑，增强了交易状态的准确性。
- 优化了 buildHistoryTx 和 buildOnChainHistoryTx 方法中的错误处理和 xpub 逻辑。
样式
- 移除了 ServiceAllNetwork 类中的控制台日志，简化了日志输出。

codesandbox[bot] commented 6 days ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

coderabbitai[bot] commented 6 days ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

此次更改涉及多个文件，主要集中在服务和工具函数的改进上。在 ServiceAllNetwork 中，删除了调试日志以简化输出。在 ServiceHistory 中，添加了新的导入，并改进了交易历史的过滤和合并逻辑。VaultBase 类的交易处理逻辑也得到了增强，错误处理更加明确。最后，在 historyUtils 中引入了新的兼容性检查函数，并在类型定义中增加了唯一标识符。

Changes

文件路径	更改摘要
packages/kit-bg/src/services/ServiceAllNetwork/ServiceAllNetwork.ts	删除了 `getAllNetworkAccountsWithEnabledNetworks` 方法中的两个控制台日志。
packages/kit-bg/src/services/ServiceHistory.ts	新增导入 `isAccountCompatibleWithTx`，并更新 `fetchAccountHistory` 和 `updateAccountLocalConfirmedTxs` 方法的逻辑。
packages/kit-bg/src/vaults/base/VaultBase.ts	更新 `buildHistoryTx` 和 `buildOnChainHistoryTx` 方法，改进了 `xpub` 处理和错误日志。
packages/shared/src/utils/historyUtils.ts	新增 `isAccountCompatibleWithTx` 函数，修改 `getOnChainHistoryTxAssetInfo` 的处理逻辑。
packages/shared/types/history.ts	在 `IOnChainHistoryTx` 类型中新增 `key` 属性。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ServiceHistory
    participant historyUtils

    User->>ServiceHistory: fetchAccountHistory(params)
    ServiceHistory->>historyUtils: isAccountCompatibleWithTx(account, tx)
    historyUtils-->>ServiceHistory: return compatibility status
    ServiceHistory-->>User: return account history

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` or `Summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

OneKeyHQ / app-monorepo