OneLemonyBoi / MiniUtilities

https://www.curseforge.com/minecraft/mc-mods/miniutilities
MIT License
13 stars 16 forks source link

[Bug Report] - Solar Panels #110

Closed Sunekaer closed 2 years ago

Sunekaer commented 2 years ago

Describe the bug

Placing multiple Mini Utilities controllers connected to Mini Utilities solar panels will exponentially increase the power produced.

Last photo in the screenshots is an array that does not tax server resources as hard. if i put solar panels between that array set to combine them all, the usage per block will be ~600μs/t per controller. In the array i have set its only 16μs/t per controller.

Steps to reproduce

Place down an array of solar controllers from Mini Utilities, they cannot touch and cannot be in a direct checkerboard pattern. Next place the solar panels down from Mini Utilities. (Placing the solar panels first will not work) Afterward connect all of the controllers outputs (at the top) to a combined input to a battery or energy sink using a flux plug to get an accurate energy reading.

Expected behaviour

Each controller should recognize and update what solar panels its using so other controllers cant take advantage. The controllers only notice if you place the panels first.

Screenshots

Screenshot_88 Screenshot_89 Screenshot_90 Screenshot_91 Screenshot_92 Screenshot_93 Screenshot_97 Screenshot_96

Additional information

If people are unaware about the μs/t of the controllers and connect a massive array it can cause a compounding influx of resource usage.

OneLemonyBoi commented 2 years ago

fixed in dev

Raidobw2 commented 2 years ago

Awesome thank you and have a nice day!

OneLemonyBoi commented 2 years ago

Reopening due to some loopholes found while testing

BrettMoan commented 2 years ago

btw, this also casues MASSIVE lag. likea single array with 8 controller and 20 solar panels can take a 20 TPS server to to 10 tps.

source: spent 3 hours looking for source of lag to no luck, adding redstone control to and/or breaking all sorts of other things during the hunt,

As soon as the panels were found, and broken, TPS shot up to from 10 -> 20 as soon as solar panels were vein mined.