OneLemonyBoi / MiniUtilities

https://www.curseforge.com/minecraft/mc-mods/miniutilities
MIT License
13 stars 16 forks source link

Fix(duplication): issues found with rotating blocks using another mod #85

Closed MichaelHillcox closed 3 years ago

MichaelHillcox commented 3 years ago

84

Our pack team found a bug in the rotation of some of your blocks, it's a really simple fix but it's a hard one to know about unless you're looking for it.

Basically, because you are trying to do custom logic on the block before it's broken, you have to check if the block was replaced with a different version of it's own block state variant. It's just annoying more than anything else. If you don't do this, you'll have a possible duplication issue like we've found here.

I've also updated your forge to 36.2.4 along with updating gradle and your dev instance. I've added a little bit extra to your workflow too allowing it to automatically build artifacts for that build. These aren't releases, just little zip files that go with the workflow, can be handy when you need people to test for you.

Bug: https://f002.backblazeb2.com/file/image-sharing/s/2021-09/vVogrVS7db.gif

OneLemonyBoi commented 3 years ago

LGTM!