OneLiberty / moonlight-chrome-tizen

A WASM port of Moonlight for Samsung Smart TV's running Tizen OS (5.5 and up)
GNU General Public License v3.0
185 stars 15 forks source link

"Esc" Key is not properly registered and shows up webpage cursor when clicked #2

Open sieskei opened 9 months ago

sieskei commented 9 months ago

Hello! Firstly, thank you for the fork; I'm glad there's some development going on. I saw the commit for 'pointing-device-support='enable'. It works great. However, I've noticed that pressing 'ESC' on the keyboard doesn't work for me. It does something like "release input devices," and I have to click with the mouse again. Do you have any idea how to fix this? Best regards, Miro!

OneLiberty commented 9 months ago

Hi ! Thanks for pointing this out, i had no clue this could happen (i'm almost always with a gamepad, the only keyboard i used was a small 2 in 1 wireless keyboard and mouse), but indeed keyboard doesn't work after pressing "esc". I don't know why but i'll be looking a bit at it.

It does something like "release input devices," and I have to click with the mouse again.

@sieskei Is it something that appears on screen, or just a guess ? I don't see anything on my end (both screen and logs)

EDIT : it's because when you press "esc" it gets out of the stream to allow you to interact with the web page directly (to close it or anything else). It's useless in our case, but i don't think this is fixable, i'll keep looking.

sieskei commented 9 months ago

Hello, Yes, exactly. You described it well - it exit for interaction in the web browser. It's quite annoying because when you're playing with the keyboard, it's impossible to navigate in the game menus.

OneLiberty commented 9 months ago

First, I've updated the name of the issue to better reflect the problem.

I tried a few implementation, unfortunately none of those worked... I've looked at the fix done for the original moonlight-chrome (https://github.com/moonlight-stream/moonlight-chrome/commit/dda060acb9d47e519f04476569997356d41e7bef?diff=split&w=0) which is really simple, but doesn't apply to our app.

Unfortunately, I don't think it's possible, it's often regarded as a safety feature (like a panic button to close a stream or something), hence why it doesn't seems possible to block it.

sieskei commented 7 months ago

@OneLiberty Any new info on this issue? Is there any way I can get involved and help with something?

OneLiberty commented 7 months ago

@sieskei Nah, nothing new, did try few things but no success ...

Is there any way I can get involved and help with something

I mean, if you have any idea of where to look, or know someone that could help. For now, I'm not entirely focused on that as I don't have many ideas left. We still could add a combo to simulate an esc key, but it clearly isn't the best solution.

I'm also looking at sending a mouse click (or else) each time to get the focus back on the app.

dcchillin46 commented 4 months ago

did we ever make progress on this? id be happy with a combo or modifier layer too. i noticed other keys like shift and tab may not be working either?

im a strategy gamer, so big bummer lol

OneLiberty commented 4 months ago

Hello there, No, no update on this.

Shift and Tab should be working as usual. it's just the "esc" key (to my knowledge). I can probably hard code a combo if you want. (Any idea of what it could be ?)

OneLiberty commented 3 months ago

So i managed to do something, not optimal tho. It needs to esc presses. The first one shows the TV cursor, and the second one refocus to the game and send a proper esc event.

Is that something that would be more interesting than a key combo ?

OneLiberty commented 2 months ago

workaround is up see commit here : esc workaround Press esc "only" two times now ...