Code cleanup and performance improvements

NonSwag commented 3 months ago

Description

This PR is rather unorganized, but in general it provides code quality and performance improvements

replaced XMaterials with Bukkit Materials
reworked how brushes work
removed unused and redundant code
abstracted brush settings to fight duplication
optimized brush algorithms
added proper error handling for fawe config creation
removed every static access to main class
organized almost every file
added a new brush called Underlay

Temporarily replaced the old broken surface mode algorithm with a simpler, faster and more intuitive one

~~known issue: exported brushes cannot be parsed anymore~~

I tested it quite a bit but cannot yet ensure that nothing else is broken

Checklist

[x] I included all information required in the sections above
[x] I tested my changes and approved their functionality
[x] I ensured my changes do not break other parts of the code
[x] Add a setting to the GUI to use either the old or new surface mode
[x] Port to fawe brushes (or as temp solution fix the parsing)

TheMeinerLP commented 3 months ago

Take a look at https://sonarcloud.io/project/issues?id=OneLiteFeatherNET_BetterGoPaint&pullRequest=17&resolved=false&sinceLeakPeriod=true

NonSwag commented 3 months ago

Take a look at https://sonarcloud.io/project/issues?id=OneLiteFeatherNET_BetterGoPaint&pullRequest=17&resolved=false&sinceLeakPeriod=true

I would rather focus on implementing i18n instead of caring about duplicated hard-coded strings I fixed a few issues that were worth it, but most parts of the system are gonna be replaced anyway (e.g. GUI, Brushes and the Utility classes)

NonSwag commented 3 months ago

I think splitting that up into three parts would make more sense First getting this PR ready to merge Second adding annotations Third documenting (or vice versa)

TheMeinerLP commented 3 months ago

Merge the second and third pr into this one. Makes more sense to me because merge chain and unstable code

NonSwag commented 3 months ago

Alright