Closed Joltras closed 1 month ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code
In the future, we should add a test for the packet to verify the link amount limit. For now, though, it looks good
Proposed changes
The current maximum number of
ServerLinks
supported by the server is hardcoded into the specific packet structure. While this behavior is generally not an issue, it becomes problematic if a situation arises where a different limit is required, as it's not possible to adjust it. This pull request introduces a flag in theServerFlag
class, which can now be modified through a parameter.Closes #83
Types of changes
What types of changes does your code introduce to this project? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.