OneLiteFeatherNET / Microtus

Up to date Minestom fork caring about community, code quality & stability
https://wiki.microtus.dev
Other
9 stars 3 forks source link

Add flag to modify the maximum amount of usable ServerLinks #85

Closed Joltras closed 1 month ago

Joltras commented 1 month ago

Proposed changes

The current maximum number of ServerLinks supported by the server is hardcoded into the specific packet structure. While this behavior is generally not an issue, it becomes problematic if a situation arises where a different limit is required, as it's not possible to adjust it. This pull request introduces a flag in the ServerFlag class, which can now be modified through a parameter.

Closes #83

Types of changes

What types of changes does your code introduce to this project? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

theEvilReaper commented 1 month ago

In the future, we should add a test for the packet to verify the link amount limit. For now, though, it looks good