search

OneLoneCoder / olcNES

NES Emulator, and Tutorial Video Code
1.36k stars 229 forks source link

Actually use revision control #18

Open TediusTimmy opened 5 years ago

TediusTimmy commented 5 years ago

This will be a polemic from a pompous arse, do forgive me. I do like your videos, however... While I realize that I am perfectly capable of diffing two of the directories that you've made (kdiff3 being my tool of choice), GitHub includes tools that allow anyone to view the differences between two commits and see what has changed. I just feel that it would be more useful to teach people how to use (git and a site like GitHub) effectively than to have them diff things themselves. If you want to go back in time, you can checkout a specific revision.

Just my unwanted two cents.

PS. Did you know that this is a thing: https://jsnes.org/

TediusTimmy commented 5 years ago

For example, see my fork https://github.com/TediusTimmy/olcNES .

Something that we can see from this: between videos 3 and 4, you added mappers 2, 3, and 66. And for the code you commit for video 5, you forgot to re-comment out these mappers.