search

OneMoreGres / qtc-cppcheck

Qt Creator Cppcheck integration plugin [deprecated]
MIT License
126 stars 37 forks source link

Fix build with current development version of Qt Creator. #40

Closed michaelweghorn closed 6 years ago

michaelweghorn commented 6 years ago

Hi,

currently, building against the development version of Qt Creator (master branch as as of commit 1773b4d) fails, since the 'IPlugin::addAutoReleasedObject' method has been removed there.

This fixes the build by using the method suggested in the respective qtcreator commit message instead.

I tested that this works for Qt Creator 4.6.1 as well, not just for the master branch.

OneMoreGres commented 6 years ago

Thanks for this PR. I'll merge it on qtc release. Btw, looks like there is no need to add options page to the pool at all. At least it works without doing it :)

michaelweghorn commented 6 years ago

Thanks for the quick reply.

If it's not needed at all, then please feel free to just remove the current call and close this PR without merging. :-) (I haven't digged deeper into the topic, but just implemented what seemed to be an obvious fix.)

orgads commented 6 years ago

Proposed a cleaner change: https://github.com/OneMoreGres/qtc-cppcheck/pull/41

michaelweghorn commented 6 years ago

I'm closing this PR in favour of a cleaner solution.