search

OneNoteDev / WebClipper

The OneNote Web Clipper extension
https://www.onenote.com/clipper
MIT License
338 stars 56 forks source link

We are not supporting Arabic RTL articles correctly #173

Open iconix opened 8 years ago

iconix commented 8 years ago

Repro URL: http://alqabas.com/304692/

Note that the preview is not right-aligned as it should be for RTL articles.

There may be other issues that I didn't detect on my quick scan.

mttwc commented 8 years ago

Looked into this briefly and for this above page, the dir attribute of rtl is set on the html tag. I'm wondering if there's any way we can reliably detect the need for rtl. For example, what if the page is a mix of rtl and ltr?

mttwc commented 8 years ago

I was digging in just now and I'd like to point out that in RTL browsers, the preview correctly RTLs the article. In OneNote clients, whether text is aligned left or right depends on the user's locale settings, so right now, the WYSIWYG preview is doing exactly what it should.