OnePlusOSS / android_kernel_msm-5.10_oneplus_sm8450

Other
37 stars 20 forks source link

Seriously OnePlus ? When do we get src we can build? #4

Open vczilla opened 1 year ago

vczilla commented 1 year ago

Lo and behold the Android 13 kernel source still doesn't compile. Several different reasons for it: the building system is picking the wrong .config fragments or rather the incomplete ones because some files that are referred to are not there. (build.config.msm.wapio.oplus ( note that waipio was also misspelt) , modules.list.oplus being also conscipcuously absent ). Even what's there wouldn't allow to build the kernel since you end up with a defconfig that lacks both CONFIG_QCOM_SMEM and CONFIG_OPLUS_FEATURE_OPROJECT that will prevent the linking phase to work.

Also talking about project_info the same annoying bugs are still there when it's trying to compile against the QCOM variant: it's using a struct file_operations for the project_info_fops variable instead of using a struct proc_ops and it's also using boot_command_line instead of saved _command_line.

Plus obviously the stock kernel is actually using gki/project_info.c and not qcom/project_info.c even though the last one gets picked up because of a config setting CONFIG_OPLUS_KERNEL_QCOM How difficult would it be to release the source to a fully working kernel ? Answer not whatsoever since Asus was able to do it .

EviraKernel commented 1 year ago

idk why oneplus stop listen dev community we wait working source wake up oneplus

Proxy13 commented 1 year ago

@OnePlusOSSAdmin

SaeedDev94 commented 1 year ago

@EviraKernel Probably because it's not OnePlus anymore, it's OPPO

Proxy13 commented 1 year ago

@vczilla maybe u can patch it using this repe.

https://github.com/severecold/oplus_oss_sm8450_kernel

vczilla commented 1 year ago

Well I patched by not using it and using Realme's kernel and vendor src code for the gt2 pro.

( Like you did with Oppo's vendor stuff I'm not mistaken).

Actually I ended up using qcom"s vanilla kernel for the waipio soc ( which was 5.10.136 ) and I slowly reintroduced Realme's vendor stuff that wasn't in qcom 's kernel .

End result for now; it boots into recovery ( stock and twrp ) ( with touchscreen working ) but not into system ( and I tried both OOS and a GSI ).

I reckon I missed something obvious regarding vendor_dlkm but I haven't found what yet .

stonmick commented 1 year ago

@OnePlusOSSAdmin, once upon a time, everyone bought your company's phones because you listened to your company's customers. Your phones could be customized, thanks to good kernel sources, but now the situation is completely different. Many people who have already fallen in love with your phones will leave you soon. Personally, I am selling my OnePlus 10 Pro and will never buy your company's phone again. I advise others to do this as well.

SaeedDev94 commented 1 year ago

@OnePlusOSSAdmin, once upon a time, everyone bought your company's phones because you listened to your company's customers. Your phones could be customized, thanks to good kernel sources, but now the situation is completely different. Many people who have already fallen in love with your phones will leave you soon. Personally, I am selling my OnePlus 10 Pro and will never buy your company's phone again. I advise others to do this as well.

Same here, No more BugPlus.

DeeparthGupta commented 1 year ago

Is this a GPL violation? It should be reported if so.

Proxy13 commented 1 year ago

@vczilla Can you share your improvements and patches with us?

which tag or branch based qcom"s vanilla kernel for the waipio soc used ?

OnePlusOSSAdmin commented 1 year ago

Following missing config file would be released. If any more file or information is needed, we'll provide. abi_gki_aarch64_oplus_internal build.config.msm.wapio.oplus modules.ext.oplus modules.list.oplus waipio_oplus.config

stonmick commented 1 year ago

Following missing config file would be released. If any more file or information is needed, we'll provide. abi_gki_aarch64_oplus_internal build.config.msm.wapio.oplus modules.ext.oplus modules.list.oplus waipio_oplus.config

oplus_project.h

OnePlusOSSAdmin commented 1 year ago

Code has been updated. https://github.com/OnePlusOSS/android_kernel_modules_and_devicetree_oneplus_sm8450/tree/oneplus/sm8450_t_13.0_10pro @stonmick oplus_project.h is located in vendor/oplus/kernel/boot/include.

yaymalaga commented 1 year ago

@OnePlusOSSAdmin Could you also check the 10T kernel missing parts? https://github.com/OnePlusOSS/android_kernel_modules_and_devicetree_oneplus_sm8475/issues/1

OnePlusOSSAdmin commented 1 year ago

@yaymalaga Sure. It'll be updated.

x1906875173 commented 1 year ago

@OnePlusOSSAdmin Will msmtool be released to users in the future?

stonmick commented 1 year ago

Code has been updated. https://github.com/OnePlusOSS/android_kernel_modules_and_devicetree_oneplus_sm8450/tree/oneplus/sm8450_t_13.0_10pro @stonmick oplus_project.h is located in vendor/oplus/kernel/boot/include.

Thanks a lot

DeeparthGupta commented 1 year ago

@OnePlusOSSAdmin Will msmtool be released to users in the future?

+1 Though I don't think this is the right place to ask this question. At the same time, OP doesn't seem to want to respond to questions like this on other channels.

OnePlusOSSAdmin commented 1 year ago

@x1906875173 @DeeparthGupta This tool is not managed by OSS team. This tool is for internal use only and there's no plan to release it to users. If you need help, you could contact customer support.

Proxy13 commented 1 year ago

is anyone boot successfully the kernel ? @vczilla

Proxy13 commented 1 year ago

@OnePlusOSSAdmin we (me and @EviraKernel ) can finally compile kernel source after months .But cant boot kernel.Phone goes black screen . are u sure source is complete ?

Proxy13 commented 1 year ago

if someone try to compile our last point is -> https://github.com/negroni-development/OOS-sm8450_t_13.0_10pro

EviraKernel commented 1 year ago

@OnePlusOSSAdmin can relase source with gki repo can syncronize and compile how Google do with pixel 7/7 pro? Source compile go all ok in build with latest source relase but go fail where try to boot same with GT2pro for realme source relase it

JimmyMultani commented 1 year ago

Hey @OnePlusOSSAdmin, it would be great if we could get a response about the kernel source not booting.

EviraKernel commented 1 year ago

Oneplus and realme relase not booting source idk why relase source when not boot this is violation of gpl so relase working build or relase a working method to build kernel

OnePlusOSSAdmin commented 1 year ago

Could you provide more detailed information. After code update, we think code is complete. It would be helpful if we could know wich specific files or configs needed. Also you could send detailed information to oss@oneplus.com

x1906875173 commented 1 year ago

Could you provide more detailed information. After code update, we think code is complete. It would be helpful if we could know wich specific files or configs needed. Also you could send detailed information to oss@oneplus.com

The problem is that we currently have no way of knowing where the problem is

EviraKernel commented 1 year ago

oss@oneplus.com actually we not idk why not boot if see on top we relase link of source gki with source updated relase it for build we have all need for boot but not boot phone go on fast boot so or relase a working method with linked clang gcc and command use to build how oneplus do or we after some months not have working kernel source becouse we build all but phone continue not boot

Proxy13 commented 1 year ago

@OnePlusOSSAdmin u can't be serious.I think the test is not too hard.Why not try compile released source and try to flash any device ? I think u are just kidding us ...

Proxy13 commented 1 year ago

@OnePlusOSSAdmin pls update 13.1 .we need tested source .

x1906875173 commented 1 year ago

@OnePlusOSSAdmin In the past, OnePlus actively listened to our opinions, recognized our problems, and supported the development of developers. Since OnePlus entered OPPO, everything has become a thing of the past. No one has successfully developed your new devices until now. You are preventing developers from developing. You must have tampered with the open source parts, and you are not willing to release the files that are missing in open source. You just want to ensure that the compilation is successful, and you are not responsible for the follow-up problems. The problem lies with you. , and are unwilling to listen to other people's opinions. Now you are only willing to release new devices and no longer support development. You have already restricted msmtool. There are always people who can test, but you are unwilling to continue to support development. It doesn't matter if you don't care, you have already violated your initial wishes.

DeeparthGupta commented 1 year ago

Msmtools was always internal and we got access to it though leaks. Thoug it's really just a modified version of a tool released by Qualcomm for public access. Regardless non-booting kernal sources is a GPL violation.

W-M-D commented 1 year ago

@OnePlusOSSAdmin In the past, OnePlus actively listened to our opinions, recognized our problems, and supported the development of developers. Since OnePlus entered OPPO, everything has become a thing of the past. No one has successfully developed your new devices until now. You are preventing developers from developing. You must have tampered with the open source parts, and you are not willing to release the files that are missing in open source. You just want to ensure that the compilation is successful, and you are not responsible for the follow-up problems. The problem lies with you. , and are unwilling to listen to other people's opinions. Now you are only willing to release new devices and no longer support development. You have already restricted msmtool. There are always people who can test, but you are unwilling to continue to support development. It doesn't matter if you don't care, you have already violated your initial wishes.

It's actually funny because the older phones are actually worth more since the OPPO merger.

W-M-D commented 1 year ago

@EviraKernel Probably because it's not OnePlus anymore, it's OPPO

yeah, i knew i should have stayed away from this state owned spyware garbage

Machad3x commented 1 year ago

@OnePlusOSSAdmin How to correctly build this kernel? We're not able to boot, you guys even tested this source?

That's a GPL violation, a kernel source need to be complete and functional.

Proxy13 commented 1 year ago

@Machad3x we did it. finally can compile kernel succesfully but device did not boot when we try. we got all kernel modules and img files. if u wanna try compile check older comments u can found complete source .

W-M-D commented 1 year ago

@Proxy13 yeah, without edl testing kernels is too risky. i'm returning

OnePlusOSSAdmin commented 1 year ago

We'll provide a guide on how to compile kernel and flash it to device. It's expected to be released in August.

x1906875173 commented 1 year ago

We'll provide a guide on how to compile kernel and flash it to device. It's expected to be released in August.

Have you ever booted the device with your own distributed kernel sources?

EviraKernel commented 1 year ago

Guide for make kernel 🤣🤣🤣 you tested source relase it and boot on phone? For kernel build major error is on build superimage stop compile and have error

OnePlusOSSAdmin commented 1 year ago

@x1906875173 Yes. We would test code before we release it to github. But internal we use the full system build, not just kernel. @EviraKernel For kernel build error, you could provide error log then we could check what's wrong. Maybe it's because of incorrect config, or other parameters that not included in the code which should be. We would improve developers' experience by releasing complete compile and install guide.

spectrum70 commented 1 year ago

Something is changed, sure, but i don't think a bad atmosphere here will bring anything good.

I am not a big expert of android, but, is it possible to enable the low level console and see where the kernel hangs ?

@OnePlusOSSAdmin is there any update ? August is near :)

OnePlusOSSAdmin commented 1 year ago

@spectrum70 There's still some work to do before it could be released to developers.

pjgowtham commented 1 year ago

Doing this fixes the issue of recovery not booting with OSS kernel modules. Maybe some touchpanel codes are incomplete. Kindly look into it when you update the source.

https://github.com/udon-development/android_device_oneplus_sm8450-common/commit/f036a8cafaf610c1a2d33d218de4c2840caeb2dd

Machad3x commented 1 year ago

@OnePlusOSSAdmin Any update about the guide or when will be released? We already in mid August.

OnePlusOSSAdmin commented 1 year ago

We could release part of work this week. Here‘s our plan. 1, release build script 2, release tool chain or download link. 3, release manifest

AngelaCooljx commented 1 year ago

hope it's also applicable to SM8475 devices

EviraKernel commented 1 year ago

@OnePlusOSSAdmin we wait no news?

stonmick commented 1 year ago

@OnePlusOSSAdmin, we are still waiting 🫠

SaeedDev94 commented 1 year ago

It seems that week will never come 😏

Machad3x commented 1 year ago

@OnePlusOSSAdmin We're still waiting! 😐