Source Release Format - Githubissues

OnePlusOSS / android_kernel_oneplus_msm8996

Other

146 stars 150 forks source link

Source Release Format #2

Open jcadduono opened 8 years ago

jcadduono commented 8 years ago

Perhaps it might be a good idea to start actually using Git version control rather than throwing generic update messages without any version information, tag references to stock update versions, or useful commit comments. This can't just be a confusing issue for the community, how are your developers communicating their changes? ><

libcg commented 8 years ago

They just squash the changes in a huge commit and push it here. It's intentional. Still better than Samsung's .tar.gz releases...

brucechiu1113 commented 7 years ago

@jcadduono

Our commit log will be as below: Synchronize codes for OxygenOS 3.5.4 The changes list: msm: mdss: update mdss perf when changing refresh rate usb: gadget: Enable DPL composition over ether tranpsort ...

Please help to check if it can meet your requirement. If you have any ideas, please feel free to let us know.

Thanks, Bruce

artem commented 7 years ago

@brucechiu1113 Do you use SVN in Oneplus?

brucechiu1113 commented 7 years ago

@ab123321 We use git in OnePlus, but I am not sure if it's appropriate to keep all git commits for each OTA updates. We need to discuss this internally. Currently, we will use the format above for next OTA update.

jcadduono commented 7 years ago

@brucechiu1113 lovely job on the N sources

https://github.com/jcadduono/android_kernel_oneplus_msm8996/commits/android-7.0 you can watch this branch get rebased and modified over the next few days as I attempt to separate the works of OnePlus and other contributors into separate commits, as well as remove some of the whitespaces and unnecessary printk's litterered throughout the kernel.

Update: You can find the bare essentials at the opensource branch. I will be adding a few small scripts to android-7.0 to assist in building.

I've sent an email to press@oneplus.net a few days ago regarding a request for a OnePlus 3T to aid with development (I don't own a OnePlus device myself, work on my projects, ex. NetHunter, LazyFlasher, and TWRP builds is done for free in my free time blindly with community feedback)

jcadduono commented 7 years ago

OxygenOS 4.0.2 release boot.img for OnePlus 3T:

dtb   =  4167613 bytes
Image = 21015552 bytes (gzip -d)

Built from OnePlus source release using provided msm-perf_defconfig:

dtb   =  2571727 bytes
Image = 20735488 bytes (gzip -d)

Ladies and gentlemen, we have an exact match!

Is anyone else getting different results?

jcadduono commented 6 years ago

I appreciate that changes are now mentioned in the squashed commits, it does make it easier to separate the squashed commits into actual commits with proper authors via cherry-picking.