Closed flar2 closed 7 years ago
I'm with you flar.
Damn shameful that we kernel developers are more GPL compliant than the company that push out the original sources.
Every Oxygen OS update must have the COMPLETE source (not the half done stuff with missing features) posted after the OTA release.
So much for the "Developer friendly" showoff...
It's no use. Their chinese politics just get in the way. I've been pressing them as much as possible, even offered to help. We're just fucked until then.
I'm very disappointed...I hope they will upload it soon.
and you advertised the phone to be developer friendly. very disappointing tbh. please please please update it. and include the other stuff missing. please
As long as they end up updating the repository, all is OK. But... what if not? A delay of two weeks since the latest OTA is alright.
@Raulvo No, it's not alright. They are violating the GPL and making things difficult for developers and users.
If they use a version control system like git, they can upload their source code changes in literally seconds. Even if they want to be purposely opaque and combine all their changes into one commit (e.g. "add OnePlus modification"), it would still only take a few minutes of effort.
@flar2
something like this? https://github.com/OnePlusOSS/android_kernel_oneplus_msm8996/commit/38dd8d898321801498f85d84f434fa7a9de2b992
@flar2 The GPL does not say anything about timing. And does not say nothing about how you can get the source. In fact, they could close this repository and still not violate the GPL. Because the source code must be available for anyone who wants it, for anyone who asks for it.
But I agree that the repository should have been already updated. Maybe they have multiple branches with the changes scattered all over them and use a script to download the source parts from the different repositories and compile. Who knows.
@Raulvo OnePlus violates the GPL in any case. Let's take a look at the options for satisfying section 3:
a) Accompany binary with source - Not satisfied b) Include written offer, valid for 3 years - Not satisfied c) Include information you received (for non-commercial use) - Not satisfied
Now, most phone manufacturers include a paragraph in the user guide / warranty info to exercise option b) as that is certainly the only way to follow the GPL for a phone, unless you want to ship the source code for the initial phone image in the phone packaging.
Well, if you interpret liberally, you can also accompany the binary by "offering access to copy from a designated place", as the end of section 3 says. But well, that's kind of grey zone.
@julian-klode I assumed OnePlus provided the GPL notice with the phone, and a link to download the source from or e-mail to contact with. I do not have the phone hehe.
Finally OP uploaded the commit!
This is bad even if its related to the chinese politics , they should not be selling off the device as international in the first place then. Three devices and they are still lacking .
History repeats itself
Hope this serious issue gets noticed.... we have the best devs complaining...update it before they leave this device like they abandoned op2 @leonfish77101 expecting a firm reply
This is OnePlus!
https://www.change.org/p/oneplus-release-sources-for-oxygen-os-we-need-more-development
Last year they released nothing and strangely now releasing everything and nothing
@leonfish77101 Are there any kernel changes in the 3.2.4 update?
OnePlus has entered a new commit LOL
@leonfish77101 When can we expect kernel source update including pocket mode?
@leonfish77101 Please, respect GPL
Problem is OnePlus is based in China. Even if someone wanted to pursue claims over intelectual property (GPL licensed code) infringement due to (partial) source non-disclosure, a Chinese court would just dismiss it. Taking the example of Hellwig vs VMware (GPL licensing claim) so far court dismissed lawsuit.
@leonfish77101 can you please update the source for the 7.0 update? It's shameful that you aren't complying with GPL.
There's plenty of good, and hugely influential developers, in this one thread criticising you. And you just sit there and do nothing?
Guys, seems that source has been pushed! https://github.com/OnePlusOSS/android_kernel_oneplus_msm8996/commit/73954d7ffb1c97acabc85c99cba4346dee2e7f6d
With super squashed commit lol
Guys, OnePlus 3/3T Android 7.0 source code has been pushed git repertory: https://github.com/OnePlusOSS/android_kernel_oneplus_msm8996.git branch: oneplus/QC8996_N
Please release updated kernel source. There have now been three OTA updates for this device since the kernel source was last updated.