Project Feedback

[OneRandomMikey]

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] Demonstrate an understanding of the CSS we've learned so far in the class
• [x] Use Flexbox to create the layout of your page
• [x] Use margin and padding to create space in and between elements
• [x] Use display block and inline-block properly
• [x] Have fun and do your best to make it pretty, the result should be something you would show to a future employer

[egillespie]

Hi @OneRandomMikey, your site doesn't appear to be uploaded to Surge. Can you please do that and comment back here when the site's available?

Thanks! 🐫

[OneRandomMikey]

I made changes.

[egillespie]

Cool, I can see the site now. 😄 I like the online resume approach. It's easy to share and should be easy to maintain. 👍

For the most part, the CSS is really well done. I've mixed in some general feedback about the structure of your resume along with stylistic elements.

Contact info

Making a list of inline-block elements works great here. I recommend changing your telephone and email address to links and changing your GitHub link to be consistently labeled like the others:

Phone: <a href="tel:517-775-1712">517-775-1712</a>
Email: <a href="mailto:zehua.li6@gmail.com">zehua.li6@gmail.com</a>
GitHub: <a href="https://github.com/OneRandomMikey">github.com/OneRandomMikey</a>

This way people can reach you using those links or they can type them if they need to (the reader may be looking at a printed version of your resume).

Swap Education and Relevant Skills

Employers care more that you can write Python than they do that you went to MSU, so put the more relevant information at the top. The images are also attention getting, so that's another good reason to put them somewhere that they'll be seen right away.

Employment history and interests

If you have relevant employment history, put that after Relevant Skills in the same style that you did your projects. I also recommend putting some extra material such as: what you're looking for in a job, hobbies, volunteer work, club memberships, etc. These extras show that you go above and beyond to stay up to date and involved in design/coding and employers eat that up!

Typography fixes

I recommend using a non-default font. A Lucida font may look great. You can also find many other great looking fonts at Google Fonts.

Some small tweaks to your lists could go a long way too. Maybe try bolding the names of the projects and italicizing the location and time period? Also, add a space between "East Lansing,MI".

---

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! :rocket:

[OneRandomMikey]

I made change.

[egillespie]

This is a little better, but I still see room for improvement in the items I pointed out:

1. The links to your telephone and email don't work. A quick search for how to link to email and phone numbers will help fix this.
2. Change the link "GitHub Page" to show the actual URL. This way someone who gets a printed version can still look up your GitHub account.
3. If you have relevant employment history or hobbies, add them. Showing anything that is above and beyond going to class and doing the required projects will give you a strong competitive advantage.
4. Your font change is not working. After you make a change, make sure it works on your computer first to avoid the hours round-trip it will take for me to notice it and tell you about it. 😉

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🦑

[OneRandomMikey]

I changed the phone link, email link and font family. I think they will work this time. For the relevant employment history or hobbies, I do not really have right now, that is why I did not add anything about those. Thank you.

[egillespie]

Niiiiice. :shipit: