Project Feedback

[OneRandomMikey]

Make a fansite based on something you like (sandwiches, movies, emo bands, etc.)

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

• [x] No code is repeated in your files; create a partial for any shared elements (nav, head, header, etc.)
• [x] Make a navigation to move throughout your site, using forEach to create a set of links to other data pages
• [x] Each item should have an object with an image, a link, a title, and more properties based on your topic (i.e. sandwich ingredients, movie release date, etc.)
• [x] Include at least 3 data pages and a homepage; routes should be created in Express for each
• [x] Use data appropriately with HTML tags (paragraphs in p tags, headings in h1-h6, etc.)
• [x] Use express.static to create a folder for static assets (images, stylesheets, etc.)
• [x] Include a .gitignore file so that node_modules and any other unnecessary files are not commited to GitHub

[egillespie]

Hi @OneRandomMikey, I don't see your website on Heroku. Did you push it?

While you're at it, can you find a way to create one template that can be used for your /ember, /riki, and /weaver routes? Furthermore, update server.js to use a forEach to generate those routes! It might look something like this:

Object.keys(heros).forEach(function (id) {
  var hero = heros[id]
  app.get(hero.link, function (request, response) {
    response.render('pages/hero', {
      heros: heros,
      hero: hero
    })
  })
})

---

After you’ve made your changes and pushed them to GitHub and your hosted site, give it a once-over to make sure it looks right, then comment back here and I’ll take another look.

Thanks! 🐉

[OneRandomMikey]

I made changes.

[egillespie]

Hi @OneRandomMikey, this looks really good. All three of your hero templates look identical. Can you remove two of them and rename the third to hero.ejs and reuse it for all of your hero pages?

Try it out and let me know when you want me to take a look! ⛳️

[OneRandomMikey]

I am not understand what exactly you want me to do. Do you want me to only have two ejs files, one for home page and another one for all three heros?

[KatieMFritz]

Jumping in so you can get un-stuck. Yes, you'll only have two views. hero.ejs will be used for all three heroes.

You might find these parts of the lesson helpful:

• https://msu.lansing.codes/courses/MI-449-SS17-740/lessons/js-serving-content-with-express/5
• https://msu.lansing.codes/courses/MI-449-SS17-740/lessons/js-serving-content-with-express/6

[KatieMFritz]

If you want more help, try sending Erik a Slack message. He'll probably see it sooner! 🚀

[OneRandomMikey]

Made changes.

[egillespie]

Nailed it! 🔨 :shipit: