search

OneSignal / OneSignal-Android-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native Android or Amazon app with OneSignal. https://onesignal.com
Other
604 stars 368 forks source link

OneSignal Push notifications for TWA apps. #1298

Closed Vegas10128 closed 3 years ago

Vegas10128 commented 3 years ago

Its the year 2021, and have yet to see any decent / clear documentation or implementation instructions for TWA apps to have OneSignal capabilities.

I have seen this thread here. https://github.com/OneSignal/OneSignal-Android-SDK/issues/868

Which was marked closed by rgomezp and only response from this user was.

"Thanks for your recommendation. We will consider adding this in the future" and "We will continue tracking this request internally"

Further more, little more investigating to find 2 solutions in same & separate thread.

implementation ('com.onesignal:OneSignal:3.12.7') { exclude group: "com.android.support", module: "customtabs" } and

implementation ('com.onesignal:OneSignal:3.12.7') { // exclude group: "com.android.support", module: "support-v4" exclude group: "com.android.support", module: "customtabs" }

But both solutions do NOT work, instead it causes errors after building application.

Manifest merger failed with multiple errors, see logs

I have also tried updating to recommended version by android studio, I have also attempted with migrate to android x,

Can we expect documentation or instructions on implementing onesignal to TWA anytime soon? If not, i will drop TWA's like a bag of bricks and consider improving more towards PWA apps.

jkasten2 commented 3 years ago

@Vegas10128 Thanks for resurfacing, I was able to reproduce the issue. I have some listed some options to fix this build error on the original issue. https://github.com/OneSignal/OneSignal-Android-SDK/issues/868#issuecomment-812253272