search

OneSignal / OneSignal-Android-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your native Android or Amazon app with OneSignal. https://onesignal.com
Other
592 stars 368 forks source link

[Bug]: Not compatible with amazon appstore sdk 3.0.5 #2128

Open joeporpeglia opened 1 week ago

joeporpeglia commented 1 week ago

What happened?

When run with amazon sdk 3.0.5, TrackAmazonPurpose triggers an NPE in this block https://github.com/OneSignal/OneSignal-Android-SDK/blob/main/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/purchases/impl/TrackAmazonPurchase.kt#L70-L86

Steps to reproduce?

1. Update amazon sdk to 3.0.5
2. Run app and initialize onesignal sdk

What did you expect to happen?

The app initializes successfully

OneSignal Android SDK version

4.8.8

Android version

13

Specific Android models

Pixel 5 Android 14

Relevant log output

No response

Code of Conduct

jkasten2 commented 1 week ago

@joeporpeglia Thanks for reporting, we will looking into addressing the compatibility.

In the meantime as a work around you can use amazon appstore sdk 3.0.4 or older until we have a fix for 3.0.5.