search

OneSignal / OneSignal-Cordova-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Ionic, PhoneGap CLI, PhoneGap Build, Cordova, or Sencha Touch app with OneSignal. Supports Android, iOS, and Amazon's Fire OS platforms. https://onesignal.com
Other
251 stars 198 forks source link

Support for TypeScript and/or Ionic Native #52

Closed nunoarruda closed 8 years ago

nunoarruda commented 8 years ago

Please make type annotations so TypeScript developers can have type checking, autocompletion support and avoid compilation/console errors:

screen shot 2016-05-08 at 08 47 42 screen shot 2016-05-08 at 08 48 34 screen shot 2016-05-08 at 21 06 19

An Ionic Native wrapper for your cordova plugin would be nice too.

jkasten2 commented 8 years ago

Thanks for the suggestions, this is a lower priority for us but feel free to fork our repo and make a pull request.

franciscogzz commented 8 years ago

Hi @nunoarruda I have the same problem ¿Could you solve this issue?

paulocarvalhodesign commented 8 years ago

Surprise that this is low priority, typescript is become ever so big and that could infact be a deal breaker for a new user, like me 😂😉

jkasten2 commented 8 years ago

Can you try window["plugins"] as a work around?

Since we support Cordova CLI, Ionic, PhoneGap Build(PGB), and Intel XDK we have in ensure any change did not break these forks.

Pull requests or any additional information on required code changes are welcome.

nunoarruda commented 8 years ago

Ionic 2 now breaks if there is any TypeScript errors. A temporary workaround is to declare window above the decorator:

declare var window;

dylanvdmerwe commented 8 years ago

Pretty certain this can be closed? http://ionicframework.com/docs/v2/native/onesignal/