OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your .NET app with OneSignal. https://onesignal.com
MIT License
16
stars
5
forks
source link
Fix iOS bindings for InAppMessages and Location #72
Tested by importing the local nuget package into a test app. This is not testable using our app included in this repository.
Affected code checklist
[ ] Notifications
[ ] Display
[ ] Open
[ ] Push Processing
[ ] Confirm Deliveries
[ ] Outcomes
[ ] Sessions
[x] In-App Messaging
[ ] REST API requests
[ ] Public API changes
Checklist
Overview
[ x I have filled out all REQUIRED sections above
[x] PR does one thing
If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[x] Any Public API changes are explained in the PR details and conform to existing APIs
Testing
[x] I have included test coverage for these changes, or explained why they are not needed
[x] All automated tests pass, or I explained why that is not possible
[x] I have personally tested this on my device, or explained why that is not possible
Final pass
[x] Code is as readable as possible.
Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[x] I have reviewed this PR myself, ensuring it meets each checklist item
WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.
Description
One Line Summary
This PR fixes the issue with InAppMessages and Location libraries not being found properly when importing from a nuget package.
Details
Fixes https://github.com/OneSignal/OneSignal-DotNet-SDK/issues/68 PR 70 attempted to fix this issue, but didn't fully resolve it. https://github.com/OneSignal/OneSignal-DotNet-SDK/pull/70 The DotNet.Targets file specifies xcframeworks to be copied into native references/resources that are consumed by Xamarin and .Net.
Motivation
Fix build issue on iOS
Scope
iOS builds
Testing
Unit testing
none
Manual testing
Tested by importing the local nuget package into a test app. This is not testable using our app included in this repository.
Affected code checklist
Checklist
Overview
Testing
Final pass