OneSignal / OneSignal-DotNet-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your .NET app with OneSignal. https://onesignal.com
MIT License
16 stars 5 forks source link

Fix iOS bindings for InAppMessages and Location #72

Closed emawby closed 11 months ago

emawby commented 11 months ago

Description

One Line Summary

This PR fixes the issue with InAppMessages and Location libraries not being found properly when importing from a nuget package.

Details

Fixes https://github.com/OneSignal/OneSignal-DotNet-SDK/issues/68 PR 70 attempted to fix this issue, but didn't fully resolve it. https://github.com/OneSignal/OneSignal-DotNet-SDK/pull/70 The DotNet.Targets file specifies xcframeworks to be copied into native references/resources that are consumed by Xamarin and .Net.

Motivation

Fix build issue on iOS

Scope

iOS builds

Testing

Unit testing

none

Manual testing

Tested by importing the local nuget package into a test app. This is not testable using our app included in this repository.

Affected code checklist

Checklist

Overview

Testing

Final pass