OneSignal / OneSignal-Flutter-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your flutter app with OneSignal
https://www.onesignal.com
Other
625 stars 214 forks source link

Fix crash when sending non-string tag values #733

Closed emawby closed 1 year ago

emawby commented 1 year ago

Description

One Line Summary

Fixes the app crashing when sending non-string tag values.

Details

Fixes #728 The addTags methods are incorrectly marked as String : Dynamic instead of String : String.

We can either convert from dynamic to string for the developer or release a breaking change to fix the types.

Motivation

Fix crash

Scope

tags

Manual testing

Tested both addTagWithKey and addTag with non-string values

Affected code checklist

Checklist

Overview

Testing

Final pass


This change is Reviewable