Fixes removeEmail calls on Android and iOS and removeSms calls on iOS
Details
Motivation
Fixes errors when calling removeEmail on Android and iOS and removeSms on iOS
Scope
No changes to the public API as fixes apply to native calls to OneSignal Android and iOS SDKs
Call arguments for removeEmail and removeSms do not have defined keys in user.dart and calling with a key returns an error on iOS.
Fix could be done one of 2 ways:
Remove the key value in OSFlutterUser.m
What was done in this PR
Add the key value defined in OSFlutterUser.m (@"email", @"smsNumber") to user.dart
This also requires the key value to be added to Android in OneSignalUser.java
Testing
Manual testing
Tested removeEmail and removeSms on an user with emails and sms subscriptions and with none, app build of the OneSignal example app on on a emulated Pixel 4 with Android 12 and physical iPhone 12 with iOS 15.5.
Affected code checklist
[ ] Notifications
[ ] Display
[ ] Open
[ ] Push Processing
[ ] Confirm Deliveries
[ ] Outcomes
[ ] Sessions
[ ] In-App Messaging
[ ] REST API requests
[ ] Public API changes
Checklist
Overview
[x] I have filled out all REQUIRED sections above
[x] PR does one thing
If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[x] Any Public API changes are explained in the PR details and conform to existing APIs
Testing
[x] I have included test coverage for these changes, or explained why they are not needed
[x] All automated tests pass, or I explained why that is not possible
[x] I have personally tested this on my device, or explained why that is not possible
Final pass
[x] Code is as readable as possible.
Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[x] I have reviewed this PR myself, ensuring it meets each checklist item
WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.
Description
One Line Summary
Fixes removeEmail calls on Android and iOS and removeSms calls on iOS
Details
Motivation
Fixes errors when calling removeEmail on Android and iOS and removeSms on iOS
Scope
No changes to the public API as fixes apply to native calls to OneSignal Android and iOS SDKs
Call arguments for removeEmail and removeSms do not have defined keys in user.dart and calling with a key returns an error on iOS. Fix could be done one of 2 ways:
Testing
Manual testing
Tested removeEmail and removeSms on an user with emails and sms subscriptions and with none, app build of the OneSignal example app on on a emulated Pixel 4 with Android 12 and physical iPhone 12 with iOS 15.5.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is