OneSignal / OneSignal-Flutter-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your flutter app with OneSignal
https://www.onesignal.com
Other
623 stars 213 forks source link

Fixed 'setMockMethodCallHandler' is deprecated | Updated minSdkVersion to 23 & compileSdkVersion to 34 #929

Open UsamaSarwar opened 3 months ago

UsamaSarwar commented 3 months ago

Description

One Line Summary

Fixed 'setMockMethodCallHandler' is deprecated | Updated minSdkVersion to 23 & compileSdkVersion to 34

Details

[Updated] minSdkVersion to 23 in build.gradle files [Updated] compileSdkVersion to 34 in build.gradle files [Fixed] 'setMockMethodCallHandler' is deprecated and shouldn't be used. Use tester.binding.defaultBinaryMessenger.setMockMethodCallHandler or TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.setMockMethodCallHandler instead. Pass the channel as the first argument. This feature was deprecated after v3.9.0-19.0.pre.

Motivation

'setMockMethodCallHandler' is deprecated and needs to be updated

Scope

This PR updates the minimum supported SDK version to 23 and the compile SDK version to 34 in the build.gradle files. It also fixes a deprecation warning related to setMockMethodCallHandler.

Testing

Unit testing

Updated 'setMockMethodCallHandler' which is deprecated.

Manual testing

It's working fine

Affected code checklist

Checklist

Overview

Testing

Final pass


This change is Reviewable