OneSignal / OneSignal-Flutter-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your flutter app with OneSignal

https://www.onesignal.com

Other

623 stars 213 forks source link

set compileSdkVersion 34 to fix build errors #935

Closed jkasten2 closed 3 months ago

jkasten2 commented 3 months ago

Description

One Line Summary

Fix lStar not found error due to compileSdkVersion being to old.

Details

Motivation

SDK should compatible with Fluter 3.24.0 and newer.

Scope

Only effect Android compile settings

Related

Fixes issue #930

Affected code checklist

[ ] Notifications
- [ ] Display
- [ ] Open
- [ ] Push Processing
- [ ] Confirm Deliveries
[ ] Outcomes
[ ] Sessions
[ ] In-App Messaging
[ ] REST API requests
[ ] Public API changes

Checklist

Overview

[X] I have filled out all REQUIRED sections above
[X] PR does one thing
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[X] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

[X] I have included test coverage for these changes, or explained why they are not needed
[X] All automated tests pass, or I explained why that is not possible
[ ] I have personally tested this on my device, or explained why that is not possible

Final pass

[X] Code is as readable as possible.
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[X] I have reviewed this PR myself, ensuring it meets each checklist item
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is

DmitryGaimaldinov commented 3 months ago

If this pull request has been merged could you please release a new version of the package with this hotfix?