Fix disableVersionCheck when GoogleServicesPlugin is applied with afterEvaluate

OneSignal / OneSignal-Gradle-Plugin

Use with OneSignal-Android-SDK to help integrate it into your Android Studio or Gradle project. https://onesignal.com

Other

64 stars 17 forks source link

Fix disableVersionCheck when GoogleServicesPlugin is applied with afterEvaluate #147

Closed jkasten2 closed 3 years ago

jkasten2 commented 3 years ago

Issue

disableGMSVersionChecks doesn't work in a case which this PR addresses.

afterEvaluate {
    rootProject.subprojects {
        if (name == "app") {
            if (!plugins.hasPlugin('com.google.gms.google-services')) {
                apply plugin: com.google.gms.googleservices.GoogleServicesPlugin
            }
        }
    }
}

Fixes

This resolves the version range issue noted in https://github.com/OneSignal/OneSignal-Cordova-SDK/issues/672
Possibly other github issues

Reviewing

Recommend reviewing commit by commit

jkasten2 commented 3 years ago

✔️ Test passed "Travis CI - Pull Request Successful in 10m — Build Passed"

Ignore failed "Travis CI - Branch Cancelled after 5m — Build Canceled" as I did cancel it on purpose as tests were running twice.