OneSignal / OneSignal-Website-SDK

OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com
Other
383 stars 114 forks source link

[Bug]: OneSignal.Notifications.permission only updated after event permissionChange is fired (160001) #1091

Open lmeurs opened 11 months ago

lmeurs commented 11 months ago

What happened?

OneSignal.Notifications.permission and OneSignal.Notifications.permissionNative are only updated after event permissionChange is fired, so the following example outputs two different permissions:

OneSignal.Notifications.addEventListener('permissionChange', function(permission) {
  console.log(permission);
  console.log(OneSignal.Notifications.permission);
});

I can imagine this is intended behaviour, but then a custom event handler cannot update the DOM relying on OneSignal.Notifications.permission and OneSignal.Notifications.permissionNative. A workaround is adding a minor timeout (ugh!) inside the event handler.

What browsers are you seeing the problem on?

Chrome (Chromium)

What operating system are you running?

W11

Steps to reproduce?

See issue description

What did you expect to happen?

See issue description

Relevant log output

No response

jkasten2 commented 11 months ago

@lmeurs Thanks for reporting!

I get your use-case here, those states should definitely match up! We will look into addressing this bug.

lmeurs commented 11 months ago

Hi @jkasten2, thank you for your comment! Do you have an update for us? Can you give an estimate when this will be picked up / fixed?