OneSignal / OneSignal-Website-SDK

OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com
Other
384 stars 116 forks source link

[Bug]: OneSignal.Notifications's event permissionChange not always fired (160001) #1092

Open lmeurs opened 1 year ago

lmeurs commented 1 year ago

What happened?

OneSignal.Notifications's event permissionChange is NOT always fired when denying/resetting permissions. In all occasions OneSignal.User.PushSubscription's event change IS fired.

UPDATE: added situation when user first denies and then resets permissions.

What browsers are you seeing the problem on?

Chrome (Chromium)

What operating system are you running?

W11

Steps to reproduce?

Denying permissions

1. Implement custom event handler for `permissionChange` on `OneSignal.Notifications`
2. Call `OneSignal.User.PushSubscription.optIn()` from button click
3. Deny permission: event is NOT fired

Resetting permissions

1. Execute steps from above
2. Reload the page, verify that permission still is denied
3. Click the padlock icon in the address bar (I am using Chrome 115)
4. Reset permissions: event is NOT fired

What did you expect to happen?

I expected next events to always be fired in this order when changing browser permissions:

  1. permissionChange on OneSignal.Notifications
  2. change on OneSignal.User.PushSubscription

But only the latter is fired when denying permission.

Relevant log output

No response

jkasten2 commented 1 year ago

@lmeurs Thanks for reporting!

We will be addressing both our permission and PushSubscription states together to fix these issues.

lmeurs commented 1 year ago

Hi @jkasten2, thank you for your comment! Do you have an update for us? Can you give an estimate when this will be picked up / fixed?