OneSignal / OneSignal-Website-SDK

OneSignal is a push notification service for web and mobile apps. This SDK makes it easy to integrate your website with OneSignal Push Notifications. https://onesignal.com

Other

383 stars 115 forks source link

[Fix] hide bell if user is subscribed, dashboard setting #1130

Closed jkasten2 closed 7 months ago

jkasten2 commented 7 months ago

Description

1 Line Summary

Fix "Hide bell if user is subscribed" that can be set in dashboard when configuring the bell.

Details

Validation

Tests

Tested on Chrome 119 on Windows 11.

Enabled the "Hide bell if user is subscribed" on the OneSignal.com dashboard and ensure the bell toggled based on both the native browser permission as well as the opt out setting.
Info

Checklist

[X] All the automated tests pass or I explained why that is not possible
[X] I have personally tested this on my machine or explained why that is not possible
[X] I have included test coverage for these changes or explained why they are not needed

Programming Checklist Interfaces:

[X] Don't use default export
[X] New interfaces are in model files

Functions:

[X] Don't use default export
[X] All function signatures have return types
[X] Helpers should not access any data but rather be given the data to operate on.

Typescript:

[X] No Typescript warnings
[X] Avoid silencing null/undefined warnings with the exclamation point

Other:

[X] Iteration: refrain from using elem of array syntax. Prefer forEach or use map
[X] Avoid using global OneSignal accessor for context if possible. Instead, we can pass it to function/constructor so that we don't call OneSignal.context

Screenshots

Dashboard option for reference:

Info

Checklist

[X] I have included screenshots/recordings of the intended results or explained why they are not needed

Related Tickets

This change is